Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp init: change ui prompts structure and output #7497

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 24, 2022

Closes #7130 and closes #6446.

Screenshots

Screen Shot 2022-03-25 at 15 04 32


Screen Shot 2022-03-25 at 15 05 36

@skshetry skshetry added ui user interface / interaction A: experiments Related to dvc exp A: cli Related to the CLI labels Mar 24, 2022
@skshetry skshetry requested a review from a team as a code owner March 24, 2022 11:24
@skshetry skshetry self-assigned this Mar 24, 2022
@skshetry skshetry requested a review from pmrowla March 24, 2022 11:24
text = ui.rich_text.assemble(
"Created ",
(self.args.name, "bright_blue"),
def _post_init_display(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the outputs have been moved out of dvc.experiments.init now (except what we need for prompts) to commands.

@dberenbaum
Copy link
Collaborator

Nice! It works really well, and I think the simplified output text is better. We can probably even drop the line with the link at the end.

I'm not sure we need so much styling specific to this command. I think we can even further simplify and make it more consistent. What do you think of this (from https://github.com/dberenbaum/dvc/tree/exp-init-ui)?

Screen Shot 2022-03-25 at 2 58 02 PM

Screen Shot 2022-03-25 at 3 00 54 PM

Light background:

Screen Shot 2022-03-25 at 3 02 09 PM

Screen Shot 2022-03-25 at 3 02 51 PM

@skshetry
Copy link
Member Author

I'm not sure we need so much styling specific to this command. I think we can even further simplify and make it more consistent. What do you think of this (from https://github.com/dberenbaum/dvc/tree/exp-init-ui)?

That makes sense, I went a bit over the top. I want to keep the last message as "You can now run your experiment" as
it's more of a tips/hints than a command. Also, first two lines being a status output, . (period) should not be there.

@skshetry
Copy link
Member Author

@dberenbaum, I’m merging this. I will iterate on top if there’s anything need to change.

@skshetry skshetry merged commit 7d0d6a3 into iterative:main Mar 29, 2022
@skshetry skshetry deleted the exp-init-ui branch March 29, 2022 10:35
@dberenbaum
Copy link
Collaborator

Looks good @skshetry! I think we can call this done for now.

@skshetry skshetry restored the exp-init-ui branch April 27, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cli Related to the CLI A: experiments Related to dvc exp ui user interface / interaction
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

exp init experience Epic: exp init
3 participants